Skip to content

Implement runAsGroup validation check#154

Open
ropatil010 wants to merge 2 commits intoopenshift:masterfrom
ropatil010:bug_fix
Open

Implement runAsGroup validation check#154
ropatil010 wants to merge 2 commits intoopenshift:masterfrom
ropatil010:bug_fix

Conversation

@ropatil010
Copy link

@ropatil010 ropatil010 commented Nov 10, 2025 •
edited
Loading

Hi Team,

Can you PTAL for the fix?

Task: https://issues.redhat.com/browse/CNTRLPLANE-1909
Issue: Doesn't show the allowed ranges in the error message.
Fix: Show the allowed ranges in the error message.

@openshift-ci openshift-ci bot requested review from ibihim and liouk November 10, 2025 14:54
@ropatil010
Copy link
Author

ropatil010 commented Nov 10, 2025

/test unit

@ropatil010 ropatil010 mentioned this pull request Nov 10, 2025
Open
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 11, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ropatil010
Once this PR has been reviewed and has the lgtm label, please assign bertinatto for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ropatil010 ropatil010 changed the title Improve error messages for group validation to show allowed ranges Implement runAsGroup validation check Nov 11, 2025
@ropatil010
Copy link
Author

ropatil010 commented Nov 11, 2025

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 11, 2025
@ropatil010
Copy link
Author

ropatil010 commented Nov 11, 2025

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 11, 2025
@ropatil010
Copy link
Author

ropatil010 commented Nov 11, 2025

/assign @haircommander

@ropatil010
Copy link
Author

ropatil010 commented Nov 11, 2025

/assign @tchap

@tchap tchap removed their assignment Nov 11, 2025
@ropatil010 ropatil010 changed the title Implement runAsGroup validation check [WIP] Implement runAsGroup validation check Nov 11, 2025
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 11, 2025
@ropatil010 ropatil010 changed the title [WIP] Implement runAsGroup validation check Implement runAsGroup validation check Nov 13, 2025
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 13, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 13, 2025

@ropatil010: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@ropatil010
Copy link
Author

ropatil010 commented Nov 20, 2025

This PR depends on openshift/api#2580

The vendor directory has been manually updated to include the API types from #2580 to enable implementation and testing. Once #2580 merges, I will:
- Update go.mod to reference the merged version
- Remove deps.diff
- Clean up vendor directory
The implementation is complete and tested, pending upstream API merge.

@ropatil010 ropatil010 mentioned this pull request Nov 20, 2025
Open
@openshift-bot
Copy link

openshift-bot commented Feb 19, 2026

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 19, 2026
@openshift-bot
Copy link

openshift-bot commented Mar 22, 2026

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci openshift-ci bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Mar 22, 2026
@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 22, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 22, 2026

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ibihim ibihim Awaiting requested review from ibihim

@liouk liouk Awaiting requested review from liouk

Assignees

@haircommander haircommander

Labels

lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ropatil010 @openshift-bot @tchap @haircommander